Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily evaluate senses #1539

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Lazily evaluate senses #1539

wants to merge 12 commits into from

Conversation

esseivaju
Copy link
Contributor

This is a prototype implementation of lazily evaluating senses. It will only be useful after switching to the InfixEvaluator, which can short-circuit senses evaluation. For now, expand the LogicEvaluator interface to support lazy evaluation. complex_intersect still uses eager evaluation as some senses need to be flipped; it's not clear how that should be supported with lazy evaluation yet.

@esseivaju esseivaju added enhancement New feature or request orange Work on ORANGE geometry engine labels Dec 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024 •
edited
Loading

Test summary

 3 901 files   6 012 suites   4m 14s ⏱️
 1 618 tests  1 589 ✅ 29 💤 0 ❌
20 006 runs  19 931 ✅ 75 💤 0 ❌

Results for commit 90ffca8.

♻️ This comment has been updated with latest results.

@esseivaju esseivaju marked this pull request as ready for review December 10, 2024 22:57
@esseivaju
Copy link
Contributor Author

I have a prototype working with the complex_intersect scenario, but it adds quite a bit of complexity. We have to associate metadata with each surface to tell if it needs to be flipped. That metadata scratch space must be cleared when evaluating a new position.

@esseivaju esseivaju mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrj sethrj Awaiting requested review from sethrj

@elliottbiondo elliottbiondo Awaiting requested review from elliottbiondo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request orange Work on ORANGE geometry engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@esseivaju